Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to do with duplicated translation contexts #10400

Closed
maxbarnas opened this issue Aug 23, 2021 · 1 comment
Closed

Decide what to do with duplicated translation contexts #10400

maxbarnas opened this issue Aug 23, 2021 · 1 comment
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:core package:find-and-replace squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@maxbarnas
Copy link
Contributor

Provide a description of the task

There are 2 translation contexts with the same ID now. I missed that while reviewing and now this is on master branch.

One is in the ui package: https://github.com/ckeditor/ckeditor5/blob/1302e2b/packages/ckeditor5-ui/src/panel/balloon/contextualballoon.js#L420

The other in find-and-replace: https://github.com/ckeditor/ckeditor5/blob/1302e2b/packages/ckeditor5-find-and-replace/src/ui/findandreplaceformview.js#L479

We can either merge them and move to the core package, but then we should come up with general enough context or we can call t() with custom ID, e.g.

t( {
	string: '%0 of %1',
	id: 'Custom %0 of %1'
} )
@maxbarnas maxbarnas added type:task This issue reports a chore (non-production change) and other types of "todos". package:core domain:ui/ux This issue reports a problem related to UI or UX. package:find-and-replace labels Aug 23, 2021
@Reinmar Reinmar added squad:core Issue to be handled by the Core team. and removed squad:compat labels Aug 24, 2021
@Reinmar
Copy link
Member

Reinmar commented Aug 24, 2021

We agreed to merge both translations and move them to core. Let's also make the context a bit more generic, e.g.:

Label for a ‘X of Y’ status of a typical next/previous navigation. For instance, ‘Page 5 of 20’.

@Reinmar Reinmar added this to the iteration 46 milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:core package:find-and-replace squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

2 participants