Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"updateCKEditor5Dependencies( { dryRun: true } )" does not terminate when pressing CTRL+C #11084

Closed
pomek opened this issue Jan 7, 2022 · 2 comments
Closed

"updateCKEditor5Dependencies( { dryRun: true } )" does not terminate when pressing CTRL+C #11084

pomek opened this issue Jan 7, 2022 · 2 comments
Labels
package:dev resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:devops Issue to be handled by the Devops team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@pomek
Copy link
Member

pomek commented Jan 7, 2022

📝 Provide detailed reproduction steps (if any)

As pointed out in ckeditor/ckeditor5-dev#737 (comment), CTRL+C does not break the process. It happens on Mac, not sure how it behaves on Windows. Make sure to verify the behavior with enabled the dry run mode.

image

✔️ Expected result

CMD+C terminates the process.

❌ Actual result

Nothing.

❓ Possible solution

See: ckeditor/ckeditor5-dev#737 (comment).

📃 Other details

  • Node: v14.18.1
@pomek pomek added type:bug This issue reports a buggy (incorrect) behavior. squad:devops Issue to be handled by the Devops team. package:dev labels Jan 7, 2022
@pomek pomek mentioned this issue Jan 7, 2022
Merged
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@pomek
Copy link
Member Author

pomek commented Oct 6, 2023

The updateCKEditor5Dependencies() function has been removed in https://github.com/ckeditor/ckeditor5-dev/releases/tag/v38.0.0. Hence, the issue is no longer valid.

@pomek pomek closed this as completed Oct 6, 2023
@pomek pomek added the resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). label Oct 6, 2023
@CKEditorBot CKEditorBot removed the resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). label Oct 6, 2023
@pomek pomek added resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). and removed status:stale labels Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:dev resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:devops Issue to be handled by the Devops team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pomek @CKEditorBot