Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making Electron an officially supported environment #1121

Closed
wwalc opened this issue Jun 29, 2018 · 3 comments
Closed

Consider making Electron an officially supported environment #1121

wwalc opened this issue Jun 29, 2018 · 3 comments
Labels
type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 19

Comments

@wwalc
Copy link
Member

wwalc commented Jun 29, 2018

This is a more generic follow up of #879.

The market share of Electron is significant, looking at e.g. https://blog.npmjs.org/post/175311966445/javascript-usage-by-industry we can read:

A surprisingly popular choice was Electron, which is obviously not a web framework at all but we included in our options. More than 20% of developers in every industry reported using Electron for some projects.

CKEditor 5 is a perfect fit for adding editing capabilities in Electron applications. In fact once we add plugins such as mentions / emoji technically one could write e.g. Slack-like application easily.
@Reinmar Reinmar added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). status:confirmed labels Jun 29, 2018
@Reinmar Reinmar added this to the next milestone Jun 29, 2018
@Reinmar
Copy link
Member

Reinmar commented Jun 29, 2018

I'm all for that. Especially that it may be quite simple as it should be a fairly modern environment.

@long-lazuli long-lazuli mentioned this issue Jul 3, 2018
Closed
@Reinmar Reinmar closed this as completed in 29ec96f Jul 5, 2018
@Reinmar Reinmar modified the milestones: next, iteration 19 Jul 5, 2018
@Reinmar
Copy link
Member

Reinmar commented Jul 5, 2018

@ma2ciek checked that everything works fine on Electron after he fixed #879. So I added it to the browser compatibility guide.

@ma2ciek
Copy link
Contributor

ma2ciek commented Jul 5, 2018 •
edited
Loading

Here's a quick start with electron:

git clone https://github.com/electron/electron-quick-start
cd electron-quick-start

Add @ckeditor/ckeditor5-build-classic": "^10.1.0" to dependencies.

npm install 
npm start

Rewrite index.html file:

<!DOCTYPE html>
<html lang="en">

<head>
	<meta charset="UTF-8">
	<title>CKEditor5 & Electron</title>
</head>

<body>
	<textarea id="ckeditor"></textarea>

	<script>
		const ClassicEditor = require( '@ckeditor/ckeditor5-build-classic' );

		ClassicEditor.create( document.getElementById( 'ckeditor' ) )
			.catch( error => {
				console.error( error );
			} );
	</script>
</body>

</html>

And run:

npm run start

Note1: It won't work for the current ckeditor5-build-classic and I had to manually run build, copy to the electron-quick-start's directory and include it as a script in index.html.

Note2: To make common shortcuts working on macOS it's required to specify the application's menu: https://electronjs.org/docs/api/menu

@Reinmar Reinmar mentioned this issue Jul 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 19
Development

No branches or pull requests
3 participants
@Reinmar @wwalc @ma2ciek