Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor crash when pasting bolded list item from Word document in RTL #13711

Closed
FilipTokarski opened this issue Mar 20, 2023 · 0 comments · Fixed by #13771
Closed

Editor crash when pasting bolded list item from Word document in RTL #13711

FilipTokarski opened this issue Mar 20, 2023 · 0 comments · Fixed by #13771
Assignees
Labels
package:list package:paste-from-office squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@FilipTokarski
Copy link
Member

📝 Provide detailed reproduction steps (if any)

  1. Open sample Word document.
  2. Copy the list item (its text has to be bolded and has to be in RTL)
  3. Paste into editor (can be RTL as well, but it happens in any editor)

✔️ Expected result

Content pastes correctly.

❌ Actual result

Crash:

Uncaught TypeError: Cannot read properties of undefined (reading 'is')
    at findListMarkerNode (list.ts:213:1)
    at findBulletedListStyle (list.ts:179:1)
    at detectListStyle (list.ts:157:1)
    at list.ts:42:1
    at Array.forEach (<anonymous>)
    at transformListItemLikeElementsIntoLists (list.ts:33:1)
    at MSWordNormalizer.execute (mswordnormalizer.ts:35:1)
    at clipboardPipeline.on.priority (pastefromoffice.ts:61:1)
    at ClipboardPipeline.fire (emittermixin.ts:146:1)
    at listenTo.priority (clipboardpipeline.ts:164:1)

📃 Other details

  • Browser: any

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@FilipTokarski FilipTokarski added type:bug This issue reports a buggy (incorrect) behavior. package:list package:paste-from-office squad:core Issue to be handled by the Core team. labels Mar 20, 2023
@martynawierzbicka martynawierzbicka added the support:2 An issue reported by a commercially licensed client. label Mar 20, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Mar 27, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Mar 27, 2023
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 28, 2023
@CKEditorBot CKEditorBot added this to the iteration 61 milestone Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:list package:paste-from-office squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants