Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Safari] Block quote and Code blocks cannot be deleted when there is no content before them. #14390

Open
michalbilik opened this issue Jun 15, 2023 · 2 comments
Open

[Safari] Block quote and Code blocks cannot be deleted when there is no content before them. #14390

michalbilik opened this issue Jun 15, 2023 · 2 comments
Labels
browser:firefox browser:safari package:block-quote package:code-block squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.

Comments

@michalbilik
Copy link

michalbilik commented Jun 15, 2023 •
edited

📝 Provide detailed reproduction steps (if any)

Scenario 1:

  1. Open Safari or Firefox.
  2. Go to https://ckeditor.com/docs/ckeditor5/latest/examples/builds-custom/full-featured-editor.html
  3. Delete all content.
  4. Insert Block quote or Code block.
  5. Try to Backspace it.

Scenario 2:

  1. Open Safari or Firefox.
  2. Go to https://ckeditor.com/docs/ckeditor5/latest/examples/builds-custom/full-featured-editor.html
  3. Delete all content.
  4. Choose Style, for instance Heading 1 (with or without slash command).
  5. Try to Backspace it.

✔️ Expected result

Scenario 1:
The Quote and Code blocks are deleted.

Scenario 2:
After the Backspace the style should be set back to Paragraph.

❌ Actual result

Scenario 1:
The Quote and Code blocks cannot be deleted when there is no content before them.
https://github.com/ckeditor/ckeditor5/assets/50703222/a0c91aab-f833-4405-98cf-67970317da17

Scenario 2:
After the Backspace the style is still set to Heading 1.
https://github.com/ckeditor/ckeditor5/assets/50703222/bd19aa75-0e34-4b3a-9a03-4b192a581032

❓ Possible solution

Regression bug from v35.3.0.
Works fine for Chrome.

For Firefox when there is no content the Backspacing is broken. So this issue and issue #14050 might be related.

📃 Other details

  • Browser: Safari Version 16.5 (18615.2.9.11.4)
  • OS: macOS 13.4 (22F66)
  • First affected CKEditor version: 35.3.0

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@michalbilik michalbilik added type:bug This issue reports a buggy (incorrect) behavior. browser:firefox browser:safari type:regression This issue reports a bug that was not present in the previous releases. squad:core Issue to be handled by the Core team. labels Jun 15, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jun 16, 2023
@Witoso Witoso mentioned this issue Jun 19, 2023
Closed
@niegowski niegowski self-assigned this Jun 19, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Jun 19, 2023
@niegowski
Copy link
Contributor

Firefox case should be fixed by #14418. But Safari has a different case, it does not crash, it simply does not fire the beforeInput event in such scenarios.

@niegowski niegowski removed their assignment Jun 19, 2023
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. labels Jun 19, 2023
@Witoso Witoso changed the title [Safari / Firefox] Block quote and Code blocks cannot be deleted when there is no content before them. [Safari] Block quote and Code blocks cannot be deleted when there is no content before them. Jun 21, 2023
@CKEditorBot CKEditorBot removed the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jun 21, 2023
@niegowski
Copy link
Contributor

DUP here: #14489

@Witoso Witoso mentioned this issue Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser:firefox browser:safari package:block-quote package:code-block squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@niegowski @Witoso @CKEditorBot @michalbilik