Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested lists with the AdjacentListsSupport plugin #14944

Open
star-szr opened this issue Sep 6, 2023 · 3 comments
Open

Support nested lists with the AdjacentListsSupport plugin #14944

star-szr opened this issue Sep 6, 2023 · 3 comments
Labels
domain:dx This issue reports a developer experience problem or possible improvement. domain:ui/ux This issue reports a problem related to UI or UX. package:list squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@star-szr
Copy link

star-szr commented Sep 6, 2023

馃摑 Provide a description of the new feature

In #13945 it mentions that the initial scope of AdjacentListsSupport does not support nested lists.

For the project I'm working on, we have a requirement for adjacent nested lists. I have been digging to find where or how to update this since I could potentially contribute this feature.

I'm filing this issue to express interest in this feature and to see if anyone can point me in the right direction. From what I have seen so far code changes may need to happen outside of the scope of the AdjacentListsSupport plugin for this to work.

Using the manual tests, you can test the AdjacentListsSupport plugin using documentlist-separator.html. Example code to test:

<ol>
  <li>One
    <ol>
      <li>1.1</li>
    </ol>
    <ol>
      <li>1.2</li>
    </ol>
  </li>
  <li>Two</li>
</ol>

Current result:

<ol>
  <li>One
    <ol>
      <li>1.1</li>
    </ol>
  </li>
</ol>
<ol>
  <li>1.2</li>
</ol>
<ol>
  <li>Two</li>
</ol>

If you'd like to see this feature implemented, add a 馃憤 reaction to this post.

@star-szr star-szr added the type:feature This issue reports a feature request (an idea for a new functionality or a missing option). label Sep 6, 2023
@star-szr
Copy link
Author

I've worked around this for now using a modified version of AdjacentListsSupport that uses a listSeparator attribute on a paragraph model rather than defining a separate listSeparator model. I think it's probably a hack and not worthy of a PR, but at this point I have spent too much time on it and I'm not sure what a more thorough solution would look like.

@wimleers
Copy link

@Witoso
Copy link
Member

Witoso commented Nov 22, 2023

Let me change it to a bug.

@Witoso Witoso added type:bug This issue reports a buggy (incorrect) behavior. package:list domain:ui/ux This issue reports a problem related to UI or UX. domain:dx This issue reports a developer experience problem or possible improvement. and removed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). labels Nov 22, 2023
@Witoso Witoso added the squad:core Issue to be handled by the Core team. label Jan 8, 2024
@aldonace-wu aldonace-wu added the support:2 An issue reported by a commercially licensed client. label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:dx This issue reports a developer experience problem or possible improvement. domain:ui/ux This issue reports a problem related to UI or UX. package:list squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants