Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font color/background remains in the view after removing it from a text with multiple attributes #2288

Closed
Mgsy opened this issue Mar 29, 2019 · 5 comments · Fixed by ckeditor/ckeditor5-engine#1719
Closed

Font color/background remains in the view after removing it from a text with multiple attributes #2288

Mgsy opened this issue Mar 29, 2019 · 5 comments · Fixed by ckeditor/ckeditor5-engine#1719
Labels
package:font type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 23

Comments

@Mgsy
Copy link
Member

Mgsy commented Mar 29, 2019

Steps to reproduce

  1. Open the font color sample.
  2. Put the caret in the first paragraph.
  3. Select whole text.
  4. Add font color, font background, bold and italic.
  5. Put the caret in the middle of the sentence.
  6. Press Enter.
  7. Select divided parts.
  8. Remove the font color/background.

Current result

The font color/background has been removed from the model but it still exists in the view.

GIF

bug_cke5
@Mgsy Mgsy changed the title Font color/background remains in the view after removing it from a text in a blockquote Font color/background remains in the view after removing it from a text Mar 29, 2019
@Mgsy Mgsy changed the title Font color/background remains in the view after removing it from a text Font color/background remains in the view after removing it from a text with multiple attributes Mar 29, 2019
@oleq
Copy link
Member

oleq commented Mar 29, 2019

Any errors? This could be the same as ckeditor/ckeditor5-remove-format#1 (review).

@Mgsy
Copy link
Member Author

Mgsy commented Apr 1, 2019

Any errors? This could be the same as ckeditor/ckeditor5-remove-format#1 (review).

Nope, no errors.

@oleq
Copy link
Member

oleq commented Apr 1, 2019

Something's wrong with the conversion. Attributes are removed correctly in the model but the view does not reflect that.

cc @msamsel

@msamsel msamsel self-assigned this Apr 1, 2019
@msamsel
Copy link
Contributor

msamsel commented Apr 1, 2019

I talked with @scofalik to help me with debugging it. He suspects that issue might be somewhere in viewWriter.

@msamsel
Copy link
Contributor

msamsel commented Apr 1, 2019

It's an upstream issue:
https://github.com/ckeditor/ckeditor5-engine/issues/1716

@msamsel msamsel removed their assignment Apr 1, 2019
Reinmar referenced this issue in ckeditor/ckeditor5-engine Apr 3, 2019
@Reinmar
Merge pull request #1719 from ckeditor/t/1716
4126359 
Fix: `view.DowncastWriter` will now correctly wrap and unwrap nested attribute elements. Closes #1716. Closes ckeditor/ckeditor5-font#30.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-font Oct 8, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:font labels Oct 8, 2019
@mlewand mlewand added this to the iteration 23 milestone Oct 8, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:font type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 23
4 participants
@oleq @mlewand @msamsel @Mgsy