Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop autoformating in BlockAutoformatEditing if callback returned false #2396

Closed
scofalik opened this issue Feb 6, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-autoformat#67
Closed

Stop autoformating in BlockAutoformatEditing if callback returned false #2396

scofalik opened this issue Feb 6, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-autoformat#67
Assignees
@scofalik
Labels
package:autoformat type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 22

Comments

@scofalik
Copy link
Contributor

scofalik commented Feb 6, 2019

To properly disable heading autoformatting when Heading command is disabled, we need to provide autoformatting cancelling in BlockAutoformatEditing if the callback returned false.
@scofalik scofalik self-assigned this Feb 6, 2019
pjasiun referenced this issue in ckeditor/ckeditor5-autoformat Feb 7, 2019
Merge pull request #67 from ckeditor/t/66
9b066f1 
Feature: Cancel `BlockAutoformatEditing` autoformatting if given callback returned `false`. Closes #66.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-autoformat Oct 9, 2019
@mlewand mlewand added this to the iteration 22 milestone Oct 9, 2019
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. package:autoformat labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:autoformat type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 22
2 participants
@scofalik @mlewand