Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of load.js and module utils #2864

Closed
Reinmar opened this issue Oct 19, 2016 · 0 comments · Fixed by ckeditor/ckeditor5-core#33
Closed

Get rid of load.js and module utils #2864

Reinmar opened this issue Oct 19, 2016 · 0 comments · Fixed by ckeditor/ckeditor5-core#33
Assignees
Labels
package:core type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 19, 2016

This has been discussed in #349 (comment).

(...) then we could totally remove the load.js stuff and the whole module.js. They only make sense in the source mode, but then you can easily use imports and you don't need loading features by strings. Side note: We have to define anyway how can you instantiate two editors with a different set of features, when using one bundle. Related tickets: ckeditor/ckeditor5-dev-bundler-rollup#1 and ckeditor/ckeditor5-core#28 and ckeditor/ckeditor5-core#27 (comment).

The point is that we implemented load.js to match the functionality of the previous approach, but it turns out that it can't really be used and, also, it isn't really needed.

In the source version of editor you have all the modules as separate files and you can import what you need and load things by config.features = [ FeatureA, FeatureB ];. In the compiled version loading by string doesn't work because all the code is bundled into one blob and the mapping between names and constructors is being lost (in the source version this mapping is represented by the file structure).

Finally, there are evidences that we'll need to name features anyway and compile the name<->constructor mapping into the editor (as a config most likely).

@Reinmar Reinmar self-assigned this Oct 19, 2016
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-core Oct 9, 2019
@mlewand mlewand added this to the iteration 4 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:core labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:core type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
2 participants