Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder should shorten log messages #30

Closed
Reinmar opened this issue Oct 6, 2015 · 2 comments
Closed

Builder should shorten log messages #30

Reinmar opened this issue Oct 6, 2015 · 2 comments
Labels
resolution:expired This issue was closed due to lack of feedback. status:stale

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 6, 2015

Followup of https://github.com/ckeditor/ckeditor5-core/issues/38.

All usages of log.error(), log.warning(), CKEditorError() must be processed and the messages should be removed (only error names should be left). Additionally, we may decide to add some validation (may be built into this step) that error messages have the correct format.

Note: Theres' no support yet for placeholders in the error messages (they were mentioned in ckeditor/ckeditor5-design#14 (comment)). I don't think we must have, so I didn't want to unnecessarily complicate things.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 2, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:expired This issue was closed due to lack of feedback. status:stale
Projects
None yet
Development

No branches or pull requests

4 participants