-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving the selection should reset the buffer #3042
Comments
ckeditor/ckeditor5-typing#21 is another case to cover when fixing this issue. |
This is very tricky, because we need to reset the buffer when selection changes... but not when that change is caused by typing. So the typing feature will need to block change buffer when they operate on the model. |
Let's try this way:
|
Prototype of fix for ckeditor/ckeditor5-typing#21 seems to help with this issue. In the meanwhile I'll add tests for the ticket. |
Manual test and early version of integration test were just commited. Also, because this issue is tightly related to ckeditor/ckeditor5-typing#21 , there will be testing of styles (Bold and/or Italic). There are obvious deficiencies e.g., lack of |
Fix: New undo step should be created on selection change or applying an attribute. Closes #20. Closes #21.
Expected: there should be 3 undo steps.
Actual: there is only one undo step.
Changing the selection should reset the buffer. That's it.
The text was updated successfully, but these errors were encountered: