Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes required by List feature. #3809

Closed
scofalik opened this issue Sep 7, 2016 · 3 comments · Fixed by ckeditor/ckeditor5-engine#584
Closed

Changes required by List feature. #3809

scofalik opened this issue Sep 7, 2016 · 3 comments · Fixed by ckeditor/ckeditor5-engine#584
Assignees
Labels
package:engine type:feature This issue reports a feature request (an idea for a new functionality or a missing option). type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@scofalik
Copy link
Contributor

scofalik commented Sep 7, 2016

This is an overall issue for changes required in engine by List feature. It also covers bugs discovered and fixed during implementing List feature. For complete list of changes look at commits in related PR.
#3603, #3604 and #3675 will be handled in this issue (and related PR), however discussion may be continued in those issues.

@Reinmar
Copy link
Member

Reinmar commented Sep 13, 2016

I reeeeeeeealy miss a list of things which changed. This is a huge PR and no word about its content.

@Reinmar
Copy link
Member

Reinmar commented Sep 13, 2016

OK, shame on me :D I haven't checked the list of issues :D.

@scofalik
Copy link
Contributor Author

scofalik commented Sep 13, 2016

As I said, you can check list of commits, but I'll copy and summarize it here for you...

Changelog:

  • Mapper now uses callbacks for position mapping.
  • Introduced Mapper#registerViewToModelLength function that takes a view element name and a function that evaluates view element length in the model.
  • Introduced RenameOperation, rename change type conversion and default callback for rename change.
  • Added: Schema#itemExtends. which enables checking whether item with name A extends item with name B.
  • Changed: view.Position#getAncestors changed order of ancestors.
  • Added: model.Position#getAncestors.
  • Changes in view.Writer: added view.Writer#breakContainer and view.Writer#mergeContainers, renamed view.Writer#breakAt to #breakAttributes and merged it with #breakRange.
  • Changed how move and remove change types are dispatched, now they are similar to insert and xxxAttribute change types (have consumable and the changed range is converted item-by-item).

Bug fixes:

  • Fixed: In AttributeOperation, 0 as attribute value was treated as no value and caused removing attribute.
  • Fixed: view.TreeWalker jumped over range boundary when creating return value.
  • Added missing LiveSelection#getLastRange() method, which lack of caused not returning default range when the method was called on empty live selection.
  • Multiple doc fixes.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 3 milestone Oct 9, 2019
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:feature This issue reports a feature request (an idea for a new functionality or a missing option). type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants