You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment, model.MarkerCollection class fires two events: add and remove. Other scripts may listen to those events as they are triggered whenever a marker is added or removed from document.
The idea is to change those events names to: add:<markerName> and remove:<markerName>. In probably all scenarios, a feature want to do something only with markers it "recognises" (by name), so each callback added to current events starts with name sniffing.
It would be cleaner and more convenient if event name already included marker name, so the callback won't even fire for wrong marker.
The text was updated successfully, but these errors were encountered:
At the moment,
model.MarkerCollection
class fires two events:add
andremove
. Other scripts may listen to those events as they are triggered whenever a marker is added or removed from document.The idea is to change those events names to:
add:<markerName>
andremove:<markerName>
. In probably all scenarios, a feature want to do something only with markers it "recognises" (by name), so each callback added to current events starts with name sniffing.It would be cleaner and more convenient if event name already included marker name, so the callback won't even fire for wrong marker.
The text was updated successfully, but these errors were encountered: