Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toJSON() should serialize nested objects #4392

Closed
oskarwrobel opened this issue Jul 27, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1493
Closed

toJSON() should serialize nested objects #4392

oskarwrobel opened this issue Jul 27, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1493
Assignees
@oskarwrobel
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 20

Comments

@oskarwrobel
Copy link
Contributor

We are changing the way of operation serialization. JSON string won't be used anymore but we still need to reduce class instance to a pure object. We need to ensure that all toJSON() calls create a proper structure including nested objects.
@oskarwrobel oskarwrobel self-assigned this Jul 27, 2018
pjasiun referenced this issue in ckeditor/ckeditor5-engine Aug 14, 2018
Merge pull request #1493 from ckeditor/t/1477
a140350 
Internal: Changed the way of data serialization. Closes #1477.
pjasiun referenced this issue in ckeditor/ckeditor5-engine Aug 14, 2018
Merge pull request #1493 from ckeditor/t/1477
27ab310 
Other: Make `toJSON()` to serialize nested objects. Closes #1477.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
@oskarwrobel oskarwrobel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarwrobel oskarwrobel

Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 20
Development

Successfully merging a pull request may close this issue.

Internal: Changed the way of data serialization. ckeditor/ckeditor5-engine
2 participants
@oskarwrobel @mlewand