Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New OT: Split x merge simple case creates different content for clients #4422

Closed
scofalik opened this issue Sep 14, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1548
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@scofalik
Copy link
Contributor

There is a problem in this scenario, where one user merges at {} and the other splits at []:

<heading>Foo</heading>{}<paragraph>B[]ar</paragraph>

After merge It becomes:

<heading>FooB[]ar</heading>

Then split at [] creates another heading:

<heading>FooB</heading><heading>ar</heading>

While on the other client there is:

<heading>Foo</heading>{}<paragraph>B</paragraph><paragraph>ar</paragraph>

And merge leaves us with paragraph:

<heading>FooB</heading><paragraph>ar</paragraph>
pjasiun referenced this issue in ckeditor/ckeditor5-engine Sep 17, 2018
Internal: Added missed special case transformation for `SplitOperation` x `MergeOperation` when the element to split got merged. Enabled `context.aWasUndone` and `context.bWasUndone` during collaboration transformation. Closes #1547.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants