You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue happens during track changes and is connected with markers transformation in undo.
Steps to reproduce
Turn on track changes mode.
Create an insertion suggestion.
Make a selection a little bigger than the suggestion.
Remove (with track changes off).
Undo, undo, redo, redo, undo.
Marker is restored only on one letter.
What happened?
When characters are inserted (step 2) separate operations are created, each for one character and one marker change.
The remove is fine. Then first undo bring back all letters together. The next undo, again, removes each letter separately. Then goes first redo. It brings back each letter separately. Then goes another redo. But it does not removes all the letters separately because it gets transformed by previous operations. So actually this becomes multiple operations. After each of those operations marker range is transformed, it gets shrunk and then it is removed when it goes to graveyard with the last letter. Then, on the last undo, the marker is brought backwith the last removed letter but it is not expanded back.
We have a mechanism that should prevent that but it has incorrect condition to kick-in at the moment. It seemed that the condition is okay, but this case shows that we need to create MarkerOperation for undo purposes (for saving marker state) more often.
The text was updated successfully, but these errors were encountered:
This issue happens during track changes and is connected with markers transformation in undo.
Steps to reproduce
What happened?
When characters are inserted (step 2) separate operations are created, each for one character and one marker change.
The remove is fine. Then first undo bring back all letters together. The next undo, again, removes each letter separately. Then goes first redo. It brings back each letter separately. Then goes another redo. But it does not removes all the letters separately because it gets transformed by previous operations. So actually this becomes multiple operations. After each of those operations marker range is transformed, it gets shrunk and then it is removed when it goes to graveyard with the last letter. Then, on the last undo, the marker is brought backwith the last removed letter but it is not expanded back.
We have a mechanism that should prevent that but it has incorrect condition to kick-in at the moment. It seemed that the condition is okay, but this case shows that we need to create
MarkerOperation
for undo purposes (for saving marker state) more often.The text was updated successfully, but these errors were encountered: