Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Document link decorators #4848

Closed
Reinmar opened this issue May 30, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-link#230
Closed

[Docs] Document link decorators #4848

Reinmar opened this issue May 30, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-link#230
Assignees
@oleq @msamsel
Labels
package:link type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Milestone
iteration 25

Comments

@Reinmar
Copy link
Member

Reinmar commented May 30, 2019

Followup after: https://github.com/ckeditor/ckeditor5-link/issues/186

The documentation should be focused first of all on showing solutions to real-life problems – e.g. controlling liink link targets in an automatic or manual ways. It can then link to the configuration option explaining that you can also use it to control things like the download attribute.

This section should be added to the link feature guide.
@oleq
Copy link
Member

oleq commented Jun 25, 2019

Since ckeditor/ckeditor5-link#222 was merged, it's our top priority to showcase decorators in the Link feature guide.

@Reinmar Reinmar assigned oleq and msamsel and unassigned msamsel Jun 27, 2019
Reinmar referenced this issue in ckeditor/ckeditor5-link Jul 1, 2019
@Reinmar
Merge pull request #230 from ckeditor/t/229
7d147b9 
Docs: Documentation for link's decorators. Closes #229.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 25 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:docs This issue reports a task related to documentation (e.g. an idea for a guide). package:link labels Oct 9, 2019
@msamsel msamsel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

@msamsel msamsel

Labels
package:link type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Projects
None yet
Milestone
iteration 25
Development

Successfully merging a pull request may close this issue.

Add documentation for link decorators. ckeditor/ckeditor5-link
4 participants
@Reinmar @oleq @mlewand @msamsel