Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ImageCommand#defaultStyle a public property #5181

Closed
scofalik opened this issue May 20, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-image#290
Closed

Make ImageCommand#defaultStyle a public property #5181

scofalik opened this issue May 20, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-image#290
Assignees
@scofalik
Labels
package:image type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 24

Comments

@scofalik
Copy link
Contributor

ImageCommand#defaultStyle is now a private property. Other features might like to use it for integration purposes. We could make it public and readonly.
@scofalik scofalik self-assigned this May 20, 2019
pjasiun referenced this issue in ckeditor/ckeditor5-image May 20, 2019
Merge pull request #290 from ckeditor/t/289
fb35177 
Feature: Changed `ImageStyleCommand#defaultStyle` from private to public readonly property. Closes #289.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 24 milestone Oct 9, 2019
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. package:image labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:image type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 24
2 participants
@scofalik @mlewand