Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ContextualBalloon manual test #5330

Closed
oskarwrobel opened this issue Apr 5, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-ui#286
Closed

Improve ContextualBalloon manual test #5330

oskarwrobel opened this issue Apr 5, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-ui#286
Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 11

Comments

@oskarwrobel
Copy link
Contributor

Follow-up: https://github.com/ckeditor/ckeditor5-ui/issues/134

After ContextualBalloon will be integrated with Link or Image and ContextualToolbar component will be introduced we can simplify ContextualToolbar manual test using above plugins/components.
@oleq
Copy link
Member

oleq commented Jun 20, 2017

Is the issue still valid?

we can simplify ContextualToolbar manual test using above plugins/components.

Did you mean ContextualBalloon manual test?

@oskarwrobel
Copy link
Contributor Author

Yes, ContextualBalloon manual test. I think this issue is still valid because CB manual test is quite complex.

oleq referenced this issue in ckeditor/ckeditor5-ui Aug 8, 2017
@oleq
Merge pull request #286 from ckeditor/t/285
cbe0297 
Fix: Views added to the `ContextualBalloon` should respect the position of the currently visible panel. Closes #285. Closes #185.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:ui labels Oct 9, 2019
This was referenced Oct 11, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 11
3 participants
@oskarwrobel @oleq @mlewand