Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiris MathType and ChemType are missing code where disabling commands disables toolbar buttons #5957

Closed
jswiderski opened this issue Dec 10, 2019 · 1 comment
Labels
package:mathtype type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jswiderski
Copy link

📝 Provide detailed reproduction steps (if any)

  1. Run CKEditor with the following code :
const commands = [ 'MathType', 'ChemType', 'link' ];
for ( const command of commands ) {
	  const commandToBlock = editor.commands.get( command );
	  commandToBlock.on( 'change:isEnabled', evt => {
		  commandToBlock.isEnabled = false;
		  evt.stop();
	  }, { priority: 'lowest' } );

	  commandToBlock.isEnabled = false;
};

✔️ Expected result

MathType and ChemType plugins toolbar buttons should be disabled and commands should not work.

❌ Actual result

Commands for MathType and ChemType plugins don't work however buttons are enabled which gives the false impression that plugins are working.

📃 Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: Any
  • Installed CKEditor plugins: MathType, ChemType

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@FilipTokarski
Copy link
Member

This issue is fixed in the new MathType version 7.19.0

@mlewand mlewand removed this from the backlog milestone Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:mathtype type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

5 participants