Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Safari] Error after undoing remove MathType equation with comment #6481

Closed
FilipTokarski opened this issue Mar 24, 2020 · 1 comment
Closed
Labels
browser:safari package:mathtype type:bug This issue reports a buggy (incorrect) behavior.

Comments

@FilipTokarski
Copy link
Member

📝 Provide detailed reproduction steps (if any)

  1. Open editor with MathType and Comments
  2. Add a MathType equation
  3. Select the equation and add a comment
  4. Remove the equation
  5. Undo

✔️ Expected result

Removal is undone, equation appears again together with comment

❌ Actual result

Editor crashes:

[Error] Unhandled Promise Rejection: TypeError: null is not an object (evaluating 'i[Hc("0x4")]')
	Uc (ckeditor.js:6:26826)
	isValidTarget (ckeditor.js:5:89529)
	(anonymous function) (ckeditor.js:5:79722)
	attachTo (ckeditor.js:5:86490)
	(anonymous function) (ckeditor.js:6:32100)
	promiseReactionJob
	parseFromString
	_toDom (ckeditor.js:5:196200)
	toView (ckeditor.js:5:196108)
	(anonymous function) (ckeditor.js:6:24486)
	view (ckeditor.js:6:24555)
	(anonymous function) (ckeditor.js:5:291919)
	fire (ckeditor.js:5:34727)
	_testAndFire (ckeditor.js:5:291210)
	convertInsert (ckeditor.js:5:288370)
	convertChanges (ckeditor.js:5:287688)
	(anonymous function) (ckeditor.js:5:301202)
	change (ckeditor.js:5:281283)
	(anonymous function) (ckeditor.js:5:301159)
	fire (ckeditor.js:5:34727)
	_handleChangeBlock (ckeditor.js:5:347976)
	_runPendingChanges (ckeditor.js:5:365243)
	enqueueChange (ckeditor.js:5:362252)
	execute (ckeditor.js:5:420128)
	(anonymous function) (ckeditor.js:5:30691)
	fire (ckeditor.js:5:34727)
	execute (ckeditor.js:5:303502)
	execute (ckeditor.js:5:367251)
	(anonymous function) (ckeditor.js:5:422748)
	fire (ckeditor.js:5:34727)
	(anonymous function) (ckeditor.js:5:25240)
	n (ckeditor.js:5:158417)
	fire (ckeditor.js:5:34727)
	i (ckeditor.js:5:165410)

24_comment1

📃 Other details

  • Browser: Safari

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@FilipTokarski
Copy link
Member Author

This issue is no longer reproducible. Closing.

@Reinmar Reinmar removed this from the backlog milestone Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:safari package:mathtype type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants