Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separator and 2 lines #817

Closed
pjasiun opened this issue Feb 5, 2018 · 3 comments
Closed

Separator and 2 lines #817

pjasiun opened this issue Feb 5, 2018 · 3 comments
Labels
package:theme-lark resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense.

Comments

@pjasiun
Copy link

pjasiun commented Feb 5, 2018

When the second line of the menu appears it looks like there is missing some lines. The border effect which we had with a single line is broken:

separator-2-lines

It is not a problem when the separator does not touch top and bottom lines:

separator-2-lines-fixed

@oleq
Copy link
Member

oleq commented Feb 5, 2018

We decided to go with full-height separators because:

  • they look great (especially when the UI is dark), setting boundaries to the dropdowns and grouping buttons,
  • this kind of wrapping is not very common,
  • if developers decide they want multi-line toolbars, they can easily customize the separator,
  • most likely, at some stage we'll have to implement a dynamic grouping mechanism anyway, which is common in many apps if only to have more control over the UI on small (mobile) screens
    image
    image

@Reinmar
Copy link
Member

Reinmar commented Feb 5, 2018

I'd add one more point to @oleq's list – developers should not accept situations where wrapping appears. It's an issue itself and should be solved so there's no wrapping.

@oleq oleq added the resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. label Feb 14, 2018
@oleq
Copy link
Member

oleq commented Feb 14, 2018

Since we ignore the case where the toolbar items wrap to the new line this issue is not valid. In the future, we may figure out some mechanism (my comment above) to handle such situations but there's no ETA for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:theme-lark resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense.
Projects
None yet
Development

No branches or pull requests

3 participants