Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor not found when importing, after creating custom build - why does premade builds work then? #8241

Closed
aske-cph opened this issue Oct 10, 2020 · 6 comments
Labels
pending:feedback This issue is blocked by necessary feedback. resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.

Comments

@aske-cph
Copy link

aske-cph commented Oct 10, 2020

Building yourself seemingly doesn't work, at least when you @import afterwards. Why is there a difference between:

  1. Adding a premade build like InlineEditor from NPM into Vue application that works like a charm. You import the editor and everything works.

  2. And Installing own build either from OnlineBuilder or building yourself with Yarn - then you can't import even though it's just another build in your node_modules folder?

✔️ Expected result

I expect to be able to build and get something you can add to your app like:
https://github.com/ckeditor/ckeditor5-build-inline

❌ Actual result

"export 'InlineEditor' was not found in 'ckeditor5-custom-build/build/ckeditor'.

when using:

import InlineEditor from 'ckeditor5-custom-build/build/ckeditor';

After both trying to create custom build with yarn, or downloading from OnlineBuilder, then adding as local package with:

npm i 'path/to/my/local/ckeditor5/build/ckeditor'

📃 Other details

  • Browser: Chrome Latest
  • OS: Ubuntu18

Again i don't understand why the build that i make myself with a few extra plugins is not "found" in the final build file? When i thought the premade builds were made in the exact same way?

Are there some extra steps i have to take to make the editor available for import?

Also thanks for an awesome editor!

--

(P.S i have tried the integration - but that seemingly doesn't work with Laravel Mix in Laravel 8 that already uses PostCss - 3 days of trying, made an issue here : laravel-mix/laravel-mix#2533, and commented here ckeditor/ckeditor5-vue#23 (comment))

@aske-cph aske-cph added the type:bug This issue reports a buggy (incorrect) behavior. label Oct 10, 2020
@aske-cph aske-cph changed the title "InlineEditor" not available when creating custom build, like when using premade build? Editor not found when importing, after creating custom build - why does premade builds work then? Oct 10, 2020
@D-Vadym
Copy link

D-Vadym commented Oct 13, 2020

I have the same problem with custom build

@Mgsy
Copy link
Member

Mgsy commented Nov 23, 2020

Hi guys, could you please provide exact step-by-step instruction on how to reproduce the issue?

@Mgsy Mgsy added the pending:feedback This issue is blocked by necessary feedback. label Nov 23, 2020
@aske-cph
Copy link
Author

aske-cph commented Jan 13, 2021

Hi again and thanks for the attention!

To reformulate my question more concisely: you seemingly can't import any custom builds as ES6 modules. You can only load them via <script> tags, as opposed to the premade builds you have available that you can import as expected.

Steps:

  1. Create any build with OnlineBuilder or build any custom build from source. (Doesn't matter what plugins or config)
  2. Import as ES6 module like you would with the premade builds.
  3. You will get an error as described above.

I ended up loading the scripts separately via script tags, which works as temporary solution. The question is why can't you just import like with the premade builds when you build yourself?

As described here #8283 there is a Vue integration guide but that gets very complex, especially when you already have an application setup with webkit which creates conflicts easily (in my case as explained didn't work because of post-css).

In essence i don't get why the premade builds export the editor but the custom don't so you have to go through a complex integration instead?

I hope this makes sense, and apologize i have overlooked an easier way to get going with a few extra plugins.

Thanks in advance for a great editor!

@websmiths
Copy link

I have the same issue. Trying to move the build process into an existing project is creating massive headaches with the build (I'm assuming conflicts within webpack & encore and all the other things that are already there.

Preferably I could just switch out my custom build (which works when imported via script tag as mentioned above) with the default ckeditor custom build, which has been working fine.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past two years. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Oct 12, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending:feedback This issue is blocked by necessary feedback. resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

5 participants