Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoftBreak should not break the AttributeElement (for example italic, bold, etc.) #9093

Open
niegowski opened this issue Feb 24, 2021 · 4 comments
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:enter squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@niegowski
Copy link
Contributor

πŸ“ Provide detailed reproduction steps (if any)

  1. Open any editor
  2. Put selection inside bolded text
  3. Press Shift+Enter

βœ”οΈ Expected result

<p>
    <strong>foo<br>bar</strong>
</p>    

❌ Actual result

πŸ“ƒ Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@niegowski niegowski added type:bug This issue reports a buggy (incorrect) behavior. package:enter squad:core Issue to be handled by the Core team. labels Feb 24, 2021
@Reinmar
Copy link
Member

Reinmar commented Mar 10, 2021

Personally, I treat this as new lines and similarly to how all styles would be repeated in a new block, here I also expect them to be repeated. Perhaps, with the exception of links.

However, I know that this is just a personal opinion and I expect developers to have different opinions here.

Finally, so far we didn't have much feedback about this which, to me, indicates that we should think twice before changing this.

@Reinmar Reinmar added this to the backlog milestone Mar 15, 2021
@Reinmar Reinmar added the domain:ui/ux This issue reports a problem related to UI or UX. label Mar 15, 2021
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@rgpublic
Copy link

I'm still interested in a solution and I think this is still valid. I also have the problem that you cannot put a br e.g. inside a hyperlink etc. I don't want two links - I'd like one link with a line break inside. That's easily possible in HTML and currently not possible to achieve with CKE5.

@danielkorte
Copy link

Related to #1068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:enter squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

7 participants