Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack item creation and destruction promises #9999

Open
ma2ciek opened this issue Jun 30, 2021 · 2 comments
Open

Stack item creation and destruction promises #9999

ma2ciek opened this issue Jun 30, 2021 · 2 comments
Labels
type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Jun 30, 2021 •
edited
Loading

The current solution probably leads to errors when the editor is being created and the watchdog tries to destroy it before it is actually created. See ckeditor/ckeditor5-react#241. 

We should rather stack these promises so after performing the createEditor and destoryEditor actions, the watchdog should wait on the first one, and once the first is ready perform the second action, and so on.
@ma2ciek ma2ciek added type:improvement This issue reports a possible enhancement of an existing feature. squad:integrations release:potential-blocker This issue potentially blocks the upcoming release (should be checked). labels Jun 30, 2021
@mlewand mlewand removed the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Jul 2, 2021
@Madejczyk
Copy link

@ma2ciek which iteration will have a fix for above issue?

@Reinmar Reinmar added squad:devops Issue to be handled by the Devops team. and removed squad:integrations labels Oct 28, 2021
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@pomek pomek removed the squad:devops Issue to be handled by the Devops team. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Reinmar @pomek @ma2ciek @mlewand @Madejczyk @CKEditorBot