Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With the current github layout, the original bar remains... and it is almost useless. #209

Closed
ShapeGroup opened this issue Jul 16, 2020 · 7 comments · Fixed by #226
Closed
Assignees
Labels
bug Something isn't working

Comments

@ShapeGroup
Copy link

Maybe not really an issue ... With the current github layout, the original bar remains. I don't know where to start, however ... If I were you I would completely replace it with yours (which is really excellent) leaving if possible a very small "hide / show original bar" button in case something goes particularly wrong.
Allow me to say this because the git bar becomes almost useless if you complete yours.

Greate job.
Good Works.

@fredck
Copy link
Contributor

fredck commented Jul 17, 2020

Thanks for the feedback and for the nice words ;)

I'm a bit confused though when you say "the original bar remains". What do you mean by that? Maybe I see something different here. Maybe you're able to show what you mean with a screenshot?

@fredck fredck added the question Further information is requested label Jul 17, 2020
@ShapeGroup
Copy link
Author

yes. I can.
 

extra:
I don't know if it's possible to add it but consider that it doesn't appear on the classics README.md but only on the wiki.
in any case it is a holy hand for the wiki. When I found out I was happy hahaha

@fredck
Copy link
Contributor

fredck commented Jul 17, 2020

Oh, that's totally clear now... and it is curious that you see the original GH toolbar. This is what I see:

This means that there is something wrong which I'm not able to reproduce here, so we would have to investigate it at your side. These are the first things that come to my mind:

  • What's your browser name and version? What's the OS?
  • Does this happens when using "Create new page" as well?
  • Do you see any error in the browser console?

Thanks for the help!

@ShapeGroup
Copy link
Author

Currently: Windows 10;
Firefox Developer 79.0b8 (64 bit);
Deactiveted all other plugin of firefox: not is chenged;
In all test, into console I have only this:
http -> developer.mozilla.org/en-US/docs/Tools/Debugger/Source_map_errors?utm_source=mozilla&utm_medium=firefox-console-errors&utm_campaign=default

ps. If I can help you I'll try. I like this plugin.  :)

@fredck fredck added bug Something isn't working and removed question Further information is requested labels Jul 17, 2020
@fredck
Copy link
Contributor

fredck commented Jul 17, 2020

Confirmed it with Firefox on mac as well. All good with Chrome.

That's good news and the first step to have this fixed soon. Thanks for the feedback, @ShapeGroup.

@fredck fredck self-assigned this Aug 19, 2020
@fredck
Copy link
Contributor

fredck commented Aug 19, 2020

I didn't identify the cause of it, but this seems to be fixed in current master.

@fredck fredck closed this as completed Aug 19, 2020
@fredck
Copy link
Contributor

fredck commented Sep 4, 2020

I've been actually misled because everything is ok with the development build of GHW. The issue is present with the production build only and I can confirm it with Firefox and Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants