Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor is initialised twice when navigating clicking "New issue" and there's no template choice #426

Closed
Dumluregn opened this issue Nov 17, 2022 · 0 comments · Fixed by #427
Assignees
Labels
bug Something isn't working squad:features

Comments

@Dumluregn
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

  1. Get the dev version of Writer.
  2. Go to the issues tab in repo without issue types, e.g. https://github.com/ckeditor/ckeditor5-mermaid/issues.
  3. Click "New issue".
  4. Examine the console.

✔️ Expected result

Only one editor should be created.

❌ Actual result

There are two instances created.
image

❓ Possible solution

Even though the issues/new/choose page is not defined and never visible, GH still walks through it and Writer finds there an element to Writify. Then navigation takes us automatically to issues/new and another instance is created. Unfortunately the first one is never destroyed (same case as #416).

📃 Other details

  • Browser: …
  • OS: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working squad:features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant