-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageData should take the image in the constructor #16
Comments
I agree or can anyone think of a use case where an empty ImageData object would be required? |
I also vote for including the image in the constructor. I cannot think of any case where we need an empty object. However, having the option to change the image data later makes sense imo. |
For ImageData we decided to enforce data in the constructor. |
Potentially, you could have an Image object which only contains the mask from the MRData class? |
InhomCorr/src/inhomcorr/interfaces/mr_data_interface.py
Line 67 in 90c0b7a
I believe it would be usefuull to just be able to set the image in the constructor. There are lots of places were we otherwise have the sequence of
I would even go so far to have the image mandatory in the init. Soi we never have an imageData that does not have an image tensor.
The text was updated successfully, but these errors were encountered: