Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a count of items, eg "(23) Bookmarks tagged coffee" #119

Open
ajft opened this issue Sep 18, 2023 · 5 comments
Open

Display a count of items, eg "(23) Bookmarks tagged coffee" #119

ajft opened this issue Sep 18, 2023 · 5 comments

Comments

@ajft
Copy link

ajft commented Sep 18, 2023

GUI improvement to display the count of items for each tag

@steve-bate
Copy link
Contributor

I have tag counts on my instance (fork). Is this what you had in mind?

@andypiper
Copy link
Collaborator

That definitely looks like what I'd imagine (and remember from sites like del.icio.us) and what is described in the issue title). I see you have a few other nice additions as well @steve-bate - the Atom "radar" icon for individual tag pages, and the +/- filtering - good work!

@ckolderup
Copy link
Owner

So I mean no offense by it, I think it's pure preference, but this is the first time someone's requested something that I don't personally want, which I knew would happen eventually!

I do appreciate that Steve's version of it has appropriate markup that I could use in a custom stylesheet to hide it 😄 I always preferred Pinboard's approach of making the tag color lighter/darker instead of adding lots of numbers to the page.

I'd definitely merge a PR from Steve (or someone reproducing how Steve implemented it), and it will motivate me to get us to a place where people can more easily reset/add to styles in a way that's compatible with using git to pull in new changes without overwriting CSS customizations.

Thanks for the report and I hope you can take my commentary in the spirit I mean it (you're obviously not alone in wanting this!)

@andypiper
Copy link
Collaborator

This is something that could potentially be configurable from a UI perspective, I think. I'm... ambivalent I guess, I think a toggle for "show bookmark counts" somewhere as a user setting would be fine.

@ckolderup
Copy link
Owner

ckolderup commented Sep 22, 2023

yeah, I could even see there being a little dropdown menu at the corner of the tags list itself that lets you toggle it on the fly? That requires more client-side JS and probably a cookie or localStorage or something... Probably an admin setting makes the most sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants