lrunzip crashed with Segmentation fault

[antonyshen]

Hi,

In Ubuntu 18.10 with the distro's lrzip, I encountered "Segmentation fault" when I tried to extract a large .lrz file (2GB in size); the version tag of lrzip in Ubuntu is 0.631+git180528-1.

Since the .lrz file that can reproduce the issue is too large in size, I uploaded it into a google drive for you to check, the URL is: https://drive.google.com/open?id=1RdXsy3lR2ouCWS7QrFUahXOngYyilLnU

The reproduce step is:

1. Running test command on the given .lrz file
   $ /usr/bin/lrunzip -vt rpi-linux-121418.tar.lrz

2. Wait for a while until the decompressing progress reaching 70%...
   /usr/bin/lrunzip -vt rpi-linux-121418.tar.lrz
   Threading is ENABLED. Number of CPUs detected: 8
   Detected 16703848448 bytes ram
   Compression level 7
   Nice Value: 19
   Show Progress
   Verbose
   Test file integrity
   Temporary Directory set as: ./
   Detected lrzip version 0.6 file.
   MD5 being used for integrity testing.
   Decompressing...
   70% 2124.42 / 3034.87 MB <== Segfault Here

3. At some point in 70% the Segmentation fault will trigger.

After checking with the version from this git repository, I found the issue may related to this commit:
cd456aa 2018-05-18 12:29:44 Fix failure to pthread join on corrupt archives calling fill_buffer again at the end of a stream

Because when I rebuilt lrzip with it I can reproduce the segfault with the command "/usr/bin/lrunzip -vt rpi-linux-121418.tar.lrz "

[ckolivas]

Alas this file is no longer available to reproduce the issue.