Implement (optional) datetime feature using chrono #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks pretty good! Make sure to also update the README though. |
|
Ok, I'll update the README and make sure everything works well with the macro |
|
@cksac How does everything look? |
|
@mekagoza looks good. Thanks for the PR. |
|
@cksac Not sure about this but it might be worth bumping the semver in Cargo.toml to 1.3 or whatever for this. I wanted to leave that in your hands |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should implement issue #11 . This is implemented using an optional Cargo feature, so it's disabled by default to minimize unnecessary dependencies and compile time. That can be changed.
@svenstaro , can you take a look over this and let me know if this is what you had in mind? The tests in
src/lib.rsare instructive, and the implementation is all insrc/faker/time.rs