Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust_decimal faking capabilities #80

Merged
merged 2 commits into from Apr 14, 2022
Merged

Conversation

asaphaaning
Copy link

@asaphaaning asaphaaning commented Apr 13, 2022

Thank you for providing this excellent tool!

This PR introduces Decimal faking.
I chose not to localize it and go with an enum for configuation. I will most likely supply more configuration options in the future :)

@asaphaaning asaphaaning marked this pull request as ready for review April 13, 2022 13:53
@cksac
Copy link
Owner

cksac commented Apr 14, 2022

thanks for the PR, why use enum for config instead of use each variant as config object?

@asaphaaning
Copy link
Author

asaphaaning commented Apr 14, 2022

thanks for the PR, why use enum for config instead of use each variant as config object?

For me to use the variants as config objects they would have to be structs, right?
I thought this was more concise but I am happy to change to what you prefer!

@cksac
Copy link
Owner

cksac commented Apr 14, 2022

yes, please use struct for each variant. thx

@asaphaaning
Copy link
Author

Already done!

@cksac cksac merged commit 50b04f1 into cksac:master Apr 14, 2022
@mothsART
Copy link
Contributor

mothsART commented Apr 14, 2022

No tests in fake/tests/determinism.rs ?

@asaphaaning
Copy link
Author

No tests in fake/tests/determinism.rs ?

Ah, will add tonight. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants