Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The save-hashes task could save only first 6 characters #47

Closed
Reinmar opened this issue Mar 15, 2017 · 2 comments
Closed

The save-hashes task could save only first 6 characters #47

Reinmar opened this issue Mar 15, 2017 · 2 comments
Assignees
@ma2ciek
Labels
resolution:solved type:enhancement

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 15, 2017

The first 6 characters are enough to identify a commit, so to not bloat the mgit.json too much it would be nice to save only them.
@pomek
Copy link
Member

pomek commented Mar 15, 2017

7*

@ma2ciek
Copy link
Contributor

ma2ciek commented Mar 15, 2017

Good issue timing - just few weeks after the first SHA-1 collision :D

@ma2ciek ma2ciek self-assigned this Jul 3, 2017
@ma2ciek ma2ciek mentioned this issue Jul 3, 2017
Merged
Reinmar added a commit that referenced this issue Jul 4, 2017
@Reinmar
Merge pull request #53 from cksource/t/47
73990c8 
Other: Shortened hashes to 7-char version in the `save-hashes` command. Closes #47.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
resolution:solved type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Reinmar @pomek @ma2ciek @Mgsy