Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable cloning from file urls (e.g. file:///workspace/myrepo/.git) #100

Merged
merged 3 commits into from
Mar 7, 2019
Merged

enable cloning from file urls (e.g. file:///workspace/myrepo/.git) #100

merged 3 commits into from
Mar 7, 2019

Conversation

neumann-d
Copy link
Contributor

@neumann-d neumann-d commented Mar 3, 2019 •
edited by pomek
Loading

Suggested merge commit message (convention)

Feature: Allows cloning packages using the file:// protocol. Closes #101.

@coveralls
Copy link

coveralls commented Mar 3, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 293

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 99.22%
Totals Coverage Status
Change from base Build 284: 0.002%
Covered Lines: 487
Relevant Lines: 487
💛 - Coveralls

@Reinmar Reinmar requested a review from pomek March 4, 2019 10:15
@pomek
Copy link
Member

pomek commented Mar 6, 2019

Hello @neumann-d. Thanks for the PR. I am going to check it out tomorrow and if everything will be fine I will merge it.

Also, I am sorry for the late response.

@pomek pomek mentioned this pull request Mar 6, 2019
Closed
@pomek
Copy link
Member

pomek commented Mar 6, 2019

I will try to write tests for this file that will cover existing options and your improvements.

@pomek pomek merged commit d0aa893 into cksource:master Mar 7, 2019
@pomek
Copy link
Member

pomek commented Mar 7, 2019

@neumann-d, thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomek pomek Awaiting requested review from pomek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neumann-d @coveralls @pomek