Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package: mgit2 => mrgit #106

Merged
merged 7 commits into from
Jul 23, 2019
Merged

Rename package: mgit2 => mrgit #106

merged 7 commits into from
Jul 23, 2019

Conversation

pomek
Copy link
Member

@pomek pomek commented Jun 17, 2019

Suggested merge commit message (convention)

Other: Renamed the package. mgit2 becomes mrgit. Closes #85.

BREAKING CHANGE: mgit2 is no longer supported. Install mrgit instead.


Additional information

Before reviewing those changes, please review #105, #108 and merge if everything works and you don't have any issues.


What to do after merging this PR:

  1. Clear all changelog and releases.
  2. Rename the repository s/mgit2/mrgit

or:

  1. Close the repository.
  2. Create a new repository (mrgit)

or:

  1. Do not clear changelog/releases and release mrgit as 1.0.0.

Then:

  1. Update CKEditor 5: Renamed and replaced usage: mgit => mrgit ckeditor/ckeditor5#1819
  2. Update CKEditor 5 dev: Renamed and replaced usage: mgit => mrgit ckeditor/ckeditor5-dev#526
  3. Check Travis Integration.
  4. Check Coveralls Integration.
  5. npm deprecate mgit2 "This package has been renamed and is not supported anymore. Install mrgit instead."

@coveralls
Copy link

coveralls commented Jun 17, 2019

Pull Request Test Coverage Report for Build 344

  • 47 of 47 (100.0%) changed or added relevant lines in 12 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.251%

Totals Coverage Status
Change from base Build 342: 0.0%
Covered Lines: 504
Relevant Lines: 504

💛 - Coveralls

|_| |_| |_|\\__, |_|\\__|
__/ |
|___/
const logo = `
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@pomek pomek marked this pull request as ready for review July 15, 2019 12:18
@pomek pomek marked this pull request as ready for review July 15, 2019 12:18
@Reinmar
Copy link
Member

Reinmar commented Jul 23, 2019

Finally, I dug deep enough in the PR queue to reach this one :D 🎉

@Reinmar Reinmar merged commit 4a2a33f into master Jul 23, 2019
@Reinmar Reinmar deleted the t/85 branch July 23, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethink name of this package
3 participants