Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap command will retry itself if failed #91

Merged
merged 4 commits into from
Nov 22, 2018
Merged

Bootstrap command will retry itself if failed #91

merged 4 commits into from
Nov 22, 2018

Conversation

pomek
Copy link
Member

@pomek pomek commented Nov 22, 2018

Suggested merge commit message (convention)

Feature: Introduced a mechanism which allows executing bootstrap command once again if it ends with an error. Closes #87.

@pomek pomek requested a review from Reinmar November 22, 2018 11:25
@pomek
Copy link
Member Author

pomek commented Nov 22, 2018

We tested it with @scofalik and seems to work.

@coveralls
Copy link

coveralls commented Nov 22, 2018

Pull Request Test Coverage Report for Build 254

  • 18 of 18 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 98.977%

Totals Coverage Status
Change from base Build 237: 0.08%
Covered Lines: 302
Relevant Lines: 304

💛 - Coveralls

lib/commands/bootstrap.js Outdated Show resolved Hide resolved
@ma2ciek
Copy link
Contributor

ma2ciek commented Nov 22, 2018

It happened to me once during the mgit update command. I'm not sure if we should patch also this command. (For now, the only one used in reset script is bootstrap, so for now it should be ok)

@pomek
Copy link
Member Author

pomek commented Nov 22, 2018

mgit update calls bootstrap if the package isn't available.

@ma2ciek
Copy link
Contributor

ma2ciek commented Nov 22, 2018

I'm not sure if we should mention in docs about this feature, but the functionality is not exposed so we can live with it.

@ma2ciek ma2ciek merged commit 47e6840 into master Nov 22, 2018
@ma2ciek ma2ciek deleted the t/87 branch November 22, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants