Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second and third argument of -se option should be optional #154

Closed
ckirsch opened this issue Feb 18, 2020 · 2 comments · Fixed by #155
Closed

Second and third argument of -se option should be optional #154

ckirsch opened this issue Feb 18, 2020 · 2 comments · Fixed by #155
Assignees
@ChrisEdel

Comments

@ckirsch
Copy link
Member

ckirsch commented Feb 18, 2020

@ChrisEdel The -se option requires at least two arguments. This is inconsistent with the usage pattern printed by selfie and the readme explaining the option. I suggest to make the second argument optional similar to the third argument (--merge-enabled) and still ignore the second and third argument in the usage pattern and readme. Can you please fix that through a PR?
@ChrisEdel
Copy link
Contributor

Sure, I will take care of that.

@ChrisEdel
Copy link
Contributor

I have created the PR. However, the travis check failed due to some docker issue with the grader (The command "docker run cksystemsteaching/selfie make grader" exited with 2.).

@ChrisEdel ChrisEdel linked a pull request Feb 25, 2020 that will close this issue
Make second argument optional #155
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisEdel ChrisEdel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make second argument optional ChrisEdel/selfie
2 participants
@ckirsch @ChrisEdel