Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as collaborator, signing the CLA does not get tracked #116

Closed
mark-kubacki opened this issue Apr 20, 2016 · 3 comments
Closed

as collaborator, signing the CLA does not get tracked #116

mark-kubacki opened this issue Apr 20, 2016 · 3 comments

Comments

@mark-kubacki
Copy link

mark-kubacki commented Apr 20, 2016

I am a collaborator with https://github.com/mholt/caddy. I have signed the CLA for a PR, and then for the entire project and I still cannot push to master due to:

$ git push mholt master

# …
remote: error: Required status check "licence/cla" is expected
To git@github.com:mholt/caddy.git
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'git@github.com:mholt/caddy.git'

I suspect that this is due to me being collaborator number 75 (due to paging?) and/or cla-assistant not having copied me to its database.

My expectation is that my git pushes don't get rejected by status check "licence/cla".

@KharitonOff
Copy link
Contributor

this issue seems not to be related to CLA assistant but to the GitHub feature "protected branches"
https://help.github.com/articles/about-protected-branches/
It looks for me like you have no push rights for master yet... could it be the reason?

@thojansen
Copy link
Contributor

CLA assistant only sets a status on commits of PRs. Even if we would set the status on commits of a given branch (e.g. like travis), you could only push to a protected branch once that commit was already pushed to another branch and the status has passed.

@mark-kubacki
Copy link
Author

Thanks for looking into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants