Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible mismatch of comment on pull request with its status #13

Closed
KharitonOff opened this issue Jan 7, 2015 · 1 comment
Closed

Possible mismatch of comment on pull request with its status #13

KharitonOff opened this issue Jan 7, 2015 · 1 comment
Labels
bug

Comments

@KharitonOff
Copy link
Contributor

Comments from CLA assistant show only the current state of CLA for the PR (whether user has signed or not the current version of CLA). So the comment can change it's description from "signed" to "not signed yet" later after the PR was merged if the content of CLA changes. That would lead to a mismatch of the PR status (green) and the comment (yellow).
@KharitonOff
Copy link
Contributor Author

better approach would be to change CLA assistant's comment on pull request instead of using generic svg image

@thojansen thojansen added the bug label Jan 20, 2015
@StrezlessMusick StrezlessMusick mentioned this issue Nov 28, 2023
Open
@StrezlessMusick StrezlessMusick mentioned this issue Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thojansen @KharitonOff