Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recheck PRs on newly added org are all pending #169

Closed
kborchers opened this issue Oct 29, 2016 · 3 comments
Closed

Recheck PRs on newly added org are all pending #169

kborchers opened this issue Oct 29, 2016 · 3 comments

Comments

@kborchers
Copy link
Contributor

After adding an org and clicking "Recheck PRs", all open PRs are checked but all come back as pending and are stuck that way.

This may be related to #150 but is a bit different in that because the org is new, there isn't even a workaround because there is no webhook payload to resend. Any thoughts appreciated. I'm also happy to help work on the solution to this and #150 but I'm new to this code base so some theories on the cause and direction where to look would be helpful.

Thanks!

@KharitonOff
Copy link
Contributor

Do I understand you correctly: the status of all PRs in the org remains "pending" even if all committers of the PRs have signed the CLA?

The workaround mentioned in #150 is actually an "old" one - "Recheck PRs" does the same. But if you wisch you can resend the webhooks also for the org. You have to just navigate into org settings and select "Webhooks" there
bildschirmfoto 2016-11-02 um 10 55 56

@kborchers
Copy link
Contributor Author

Sorry, I believe this issue was filed before I fully understood how things work. I was not expecting the unsigned CLA to leave the status as pending but expected it to fail the check. If the expected outcome is for the check to always be pending until the CLA is signed, this is working properly and you can close this issue. If it should actually fail the check, then it is not doing that.

@KharitonOff
Copy link
Contributor

No problem. CLA assistant check has indeed only two statuses: pending and success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants