Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status check not working #200

Closed
matz3 opened this issue Mar 7, 2017 · 4 comments
Closed

Status check not working #200

matz3 opened this issue Mar 7, 2017 · 4 comments

Comments

@matz3
Copy link
Contributor

matz3 commented Mar 7, 2017

PR: SAP/openui5#1363

CLA has been signed, but the status is still not signed yet. Re-check from PR comment and from admin UI didn't work.

Redirect seems to be broken aswell, see SAP/openui5#1363 (comment).

@KharitonOff
Copy link
Contributor

Hi Matthias,

CLA assistant checks the signatures of the committers of the PR, so @sbell-bluefin and not @stu-b-doo should sign the CLA.

@stu0292
Copy link

stu0292 commented Mar 7, 2017

ah, that's my old account. Need to change my git email address. Successfully signed - thanks!

@matz3
Copy link
Contributor Author

matz3 commented Mar 7, 2017

@KharitonOff thanks! I missed that. Would be helpful to show the username if it differs from the one opening the PR.

@sbell-bluefin
Copy link

Also worth pointing out that the first time I tried signing this from the committer's github account - I accessed the PR while logged in as the committer but the assistant's 'sign me in with github' was picking up the other account, which was also logged in in a different tab, same browser session.

Not saying this is something that needs fixing as such, just something to be aware of in case of similar issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants