Questions about the way of handling webhook event

[MichaelTsengLZ]

Since I'm making some changes, I'm confused by the code which handles webhook event. For me, cla.check() is able to handle a webhook event. The function handleWebhook() first get commits(but don't use the commits) and then call cla.check(). I feel it's really redundant. Could anyone give me some guidance?

[thojansen]

@KharitonOff would be the right one to help out here 😃

[KharitonOff]

The main reason of getting commits first and calling cla.check() afterwards is the problem with GitHub API we faced lately: sometimes the PR API (https://developer.github.com/v3/pulls/#list-commits-on-a-pull-request) didn't respond with appropriate data straight after the PR was created, it took a bit of time until the API responded as expected.

So, in order to handle this latency I added this api-call before check() and the timeout function for the case the GitHub API response has no data yet.