Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the CLA assistant handle CLA signed by organisations #414

Closed
AloisReitbauer opened this issue Feb 13, 2019 · 12 comments
Closed

Can the CLA assistant handle CLA signed by organisations #414

AloisReitbauer opened this issue Feb 13, 2019 · 12 comments
Labels

Comments

@AloisReitbauer
Copy link

Is there a way to add an entire organization as whitelisted for contribution. I understand how it will work for individual users. In case of corporate CLAs you will want the members of a Github group be able contribute.

Is this currently supported? If not, where in the code would this be added ideally.

@KharitonOff
Copy link
Contributor

There is a PR open, which already addresses your request: #410
I hope it is ok for you to wait until we'll be able to merge it.

@AloisReitbauer AloisReitbauer changed the title Can the CLA assistant handled CLA signed by organisations Can the CLA assistant handle CLA signed by organisations Feb 13, 2019
@KharitonOff
Copy link
Contributor

@AloisReitbauer now you can test this feature on https://cla-assistant.io

@andyleejordan
Copy link

@KharitonOff I am trying to test this feature, but when I add my organization name to the whitelist, it just complains:

"Authentication required"

I am not sure what's up :/

@andyleejordan
Copy link

@KharitonOff I am trying to test this feature, but when I add my organization name to the whitelist, it just complains:

"Authentication required"

I am not sure what's up :/

Well that's bizarre. I closed and re-opened and what do you know? It was some cache issue. So that worked.

@andyleejordan
Copy link

Well, that's unfortunate. I tried whitelisting the openenclave GitHub organization (of which I am the sole member) and opening a test here: https://github.com/openenclave/test-repo/pull/3 but that doesn't seem to work as I expected, it still wants me to sign the CLA.

@KharitonOff
Copy link
Contributor

KharitonOff commented Apr 10, 2019

@andschwa sorry for long delay and thank you very much for pointing out this issue! The problem should be fixed now. Can you try and confirm, please?

@andyleejordan
Copy link

@KharitonOff Cool! Ok, it works as expected for users of some org making a PR to repos in the same org. Thank you!

However, my understanding of the implemented logic leads me to believe that it won't let me whitelist authors from some external org making contributions directly in m,y repo. Instead, the logic lets me whitelist PRs made from some external org's fork. Is that right? If so, I can work with that, though it'd be nice to do a membership test 😄

@KharitonOff
Copy link
Contributor

Yes, you are right, there is no membership check. I suppose you'd prefer to have a solution like @BenLloydPearson described in #403
In case you'd like to become an active contributor to CLA assistant you can synch with Ben and jointly develop a possible solution 😄I will be happy to provide you with all information you may need.

@andyleejordan
Copy link

Thanks @KharitonOff! I will keep that in mind and let you know (I'd be doing it for work so I'd need to make sure I have time).

@stale
Copy link

stale bot commented Jul 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Oct 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 9, 2019
@ibakshay
Copy link
Contributor

ibakshay commented Oct 9, 2019

I will close this issue as the CLA Assistant can handle CLA signed by organisations now and the Membership Check functionality is also implemented.

@ibakshay ibakshay closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants