-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can the CLA assistant handle CLA signed by organisations #414
Comments
There is a PR open, which already addresses your request: #410 |
@AloisReitbauer now you can test this feature on https://cla-assistant.io |
@KharitonOff I am trying to test this feature, but when I add my organization name to the whitelist, it just complains: "Authentication required" I am not sure what's up :/ |
Well that's bizarre. I closed and re-opened and what do you know? It was some cache issue. So that worked. |
Well, that's unfortunate. I tried whitelisting the |
@andschwa sorry for long delay and thank you very much for pointing out this issue! The problem should be fixed now. Can you try and confirm, please? |
@KharitonOff Cool! Ok, it works as expected for users of some org making a PR to repos in the same org. Thank you! However, my understanding of the implemented logic leads me to believe that it won't let me whitelist authors from some external org making contributions directly in m,y repo. Instead, the logic lets me whitelist PRs made from some external org's fork. Is that right? If so, I can work with that, though it'd be nice to do a membership test 😄 |
Yes, you are right, there is no membership check. I suppose you'd prefer to have a solution like @BenLloydPearson described in #403 |
Thanks @KharitonOff! I will keep that in mind and let you know (I'd be doing it for work so I'd need to make sure I have time). |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I will close this issue as the CLA Assistant can handle CLA signed by organisations now and the Membership Check functionality is also implemented. |
Is there a way to add an entire organization as whitelisted for contribution. I understand how it will work for individual users. In case of corporate CLAs you will want the members of a Github group be able contribute.
Is this currently supported? If not, where in the code would this be added ideally.
The text was updated successfully, but these errors were encountered: