Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does cla-assistant want public_repo scope? #417

Closed
superbrothers opened this issue Feb 25, 2019 · 3 comments
Closed

Why does cla-assistant want public_repo scope? #417

superbrothers opened this issue Feb 25, 2019 · 3 comments

Comments

@superbrothers
Copy link

superbrothers commented Feb 25, 2019

Hi, I have a question that is why does cla-assistant want public_repo scope?

According to #78 (comment), @KharitonOff said "public_repo - read all public repositories in order to provide a selection of your repos to set it up", but no scope can also read all public repos.

  • (no scope): Grants read-only access to public information (includes public user profile info, public repository info, and gists)

https://developer.github.com/apps/building-oauth-apps/understanding-scopes-for-oauth-apps/

Therefore I guess cla-assistant does not need public_repo if the scope is only used for reading public repos.

@KharitonOff
Copy link
Contributor

Thanks for pointing out! We'll check on it in our time.

@superbrothers
Copy link
Author

Are there any updates?

@KharitonOff
Copy link
Contributor

@superbrothers I've removed the scope. But the change will come with the next major release first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants