Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

success modal view has no header any more #52

Closed
KharitonOff opened this issue Jun 3, 2015 · 7 comments
Closed

success modal view has no header any more #52

KharitonOff opened this issue Jun 3, 2015 · 7 comments

Comments

@KharitonOff
Copy link
Contributor

@yaseminc what do you think from design perspective?

commit file reference pull request
cc00398 src/client/modals/templates/linkSuccess.html#L3 #50 #50
@KharitonOff
Copy link
Contributor Author

bildschirmfoto 2015-06-03 um 10 14 29

@yaseminc
Copy link
Contributor

yaseminc commented Jun 3, 2015

was there a specific reason to leave it out?

@KharitonOff
Copy link
Contributor Author

I suppose the the header and the content were repeating each other. Maybe we can use another wording there, like "Well done" or "Success", "Congrats" ...
@yaseminc, @dfarr what do you think about it?

@yaseminc
Copy link
Contributor

yaseminc commented Jun 8, 2015

I thought it already said "success"?

@KharitonOff
Copy link
Contributor Author

it was "You created a new link!"
@yaseminc should I take "Success"?

@KharitonOff
Copy link
Contributor Author

I'm not sure if it's better now or not. @yaseminc ?

bildschirmfoto 2015-06-09 um 16 34 58

@yaseminc
Copy link
Contributor

yaseminc commented Jun 9, 2015

I am not sure either. First, the space above and beneath 'Success' is definitely too much... My view is first led to the illustration, then to the button, afterwards I read the text below the illustration. The headline is floating and the words double in the meaning.. @KharitonOff could you send me a shot of the very first mockup I did for this to compare, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants