Cancel spot requests when associated instances are terminated #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using one-time spot requests, the instances are terminated, but the spot request is not cancelled, leaving the door open to being filled again in the future. This PR deletes the spot request if it exists in the aws delete_proxy() function. Related to claffin#42, but unclear if applicable to persistent spot requests.
|
Looking into this a little further, per https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/spot-requests.html, it looks like one-time requests are closed if the instance is terminated, and this pr proactively cancels the request instead of waiting for ec2 to do it eventually. Additional testing seems to indicate we can also cancel persistent spot requests and thus prevent future undesired spin ups of associated instances per #42. I've updated the condition to be applicable to both spot requests accordingly. |
|
Excellent PR, thank you for your contribution. I've tested this now, it does what's described and fixes issue #42. I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting proxies filled by one-time spot requests, the instances are terminated, but the spot request itself is not cancelled, leaving the door open to being filled again in the future when not associated with cloudproxy. This PR deletes the spot request if it exists in the delete_proxy() function. Related to #42, but unclear if applicable to persistent spot requests.