Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLAHub should subscribe to more GitHub hook events #47

Closed
jasonm opened this issue May 1, 2013 · 3 comments · Fixed by #97
Closed

CLAHub should subscribe to more GitHub hook events #47

jasonm opened this issue May 1, 2013 · 3 comments · Fixed by #97
Assignees
Labels

Comments

@jasonm
Copy link
Member

jasonm commented May 1, 2013

CLAHub knows to look and check the signature status on commits because it receives webhooks from GitHub notifying it of new commits.

Currently, CLAHub only handles to the "push" event: https://github.com/clahub/clahub/blob/master/app/controllers/github_webhooks_controller.rb#L7

It should handle more events, like "pull_request" - here is a list of the events: http://developer.github.com/v3/repos/hooks/

@jasonm
Copy link
Member Author

jasonm commented May 1, 2013

Note to self: let Om know when this is updated.

@HimanGamage
Copy link

Can you resolve this issue ASAP. We need to verify the pull request before merge.

@jasonm
Copy link
Member Author

jasonm commented Oct 11, 2014

Hi @HimanGamage - Thanks for checking out CLAHub, but I only work on this in my free time, so I can't promise any particular deadlines. I'm always happy to take time to review a PR for the functionality, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants