Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcode setting for numaNodeCount under NUMA mode #13

Open
troore opened this issue Jul 8, 2024 · 0 comments
Open

Hardcode setting for numaNodeCount under NUMA mode #13

troore opened this issue Jul 8, 2024 · 0 comments

Comments

@troore
Copy link

troore commented Jul 8, 2024

Hi @clamchowder,

I found in MemoryBandwidth.c, under NUMA mode, there is a hardcode number (https://github.com/clamchowder/Microbenchmarks/blob/master/MemoryBandwidth/MemoryBandwidth.c#L620):

image

As the comment indicates, it may be for KNL. So should we recover the numaNodeCount back to numa_max_node() + 1 for other CPUs?

Thanks,
troore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@troore