Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddUsing tweak doesn't traverse same-level anon namespaces #1572

Open
kadircet opened this issue Apr 3, 2023 · 2 comments
Open

AddUsing tweak doesn't traverse same-level anon namespaces #1572

kadircet opened this issue Apr 3, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kadircet
Copy link
Member

kadircet commented Apr 3, 2023

a.cc:

namespace ns { struct Foo; struct Bar; }
namespace { using ns::Foo; }

void foo() { ns::^Foo *f; ns::^Bar *b; }

Triggering action on first point should only drop the qualifier and second one should insert the using decl into the anon namespace.

@kadircet kadircet added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Apr 3, 2023
@chouzz
Copy link

chouzz commented Jul 20, 2023

I use clangd every day and very interest in it. I would like to contribute to clangd.

I've fixed this issue and added test cases, but I'm not sure if my fix is a best practice, will submit my patch later.

@chouzz
Copy link

chouzz commented Jul 28, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants