Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multicall has a performance impact on start-up #2866

Closed
2 tasks done
Tracked by #215 ...
fishface60 opened this issue Oct 12, 2021 · 0 comments · Fixed by #3041
Closed
2 tasks done
Tracked by #215 ...

Multicall has a performance impact on start-up #2866

fishface60 opened this issue Oct 12, 2021 · 0 comments · Fixed by #3041
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-enhancement Category: Raise on the bar on expectations

Comments

@fishface60
Copy link
Contributor

Please complete the following tasks

  • I have searched the discussions
  • I have searched the existing issues

Clap Version

3.0.0-beta.4

Describe your use case

AppSettings::Multicall causes it to check the executable name against all applet names first and then later against the program name.

If the base program name is not the same as any applets we can match against it first, which may be faster if we expect to access it via that name more often than as an applet link.

Describe the solution you'd like

We can know in advance that the base program name is not the same as an applet by checking the name of an added subcommand against the base program name and set an internal flag to match against base program name first.

Alternatives, if applicable

We could WONTFIX this as we don't expect program start-up to be hot code.

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-enhancement Category: Raise on the bar on expectations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants